Skip to content

feat : add token-2022 core ixs and state #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 9, 2025
Merged

feat : add token-2022 core ixs and state #190

merged 4 commits into from
Aug 9, 2025

Conversation

@Nagaprasadvr
Copy link
Contributor

@Nagaprasadvr Nagaprasadvr commented Jul 2, 2025 •
edited
Loading

@febo

  1. Add token-2022 core ixs and state
  2. additional param - program_id is included in token-2022 which can be used to invoke both token and token-2022 ixs
  3. this pr only included common ixs between token and token-2022 , i plan to open new prs to add other ixs and extensions as well
  4. add #[inline(always)] for all invoke_signed methods

@Nagaprasadvr Nagaprasadvr force-pushed the feat-add-token-2022-core-state-and-ixs branch 2 times, most recently from 6f0312e to e2f66e6 Compare July 2, 2025 05:04
@Nagaprasadvr Nagaprasadvr changed the title add token-2022 core ixs and state feat : add token-2022 core ixs and state Jul 2, 2025
febo
febo reviewed Jul 2, 2025
View reviewed changes
febo
febo reviewed Jul 2, 2025
View reviewed changes
febo
febo reviewed Jul 2, 2025
View reviewed changes
febo
febo reviewed Jul 2, 2025
View reviewed changes
febo
febo reviewed Jul 2, 2025
View reviewed changes
febo
febo reviewed Jul 2, 2025
View reviewed changes
febo
febo reviewed Jul 2, 2025
View reviewed changes
febo
febo reviewed Jul 2, 2025
View reviewed changes
febo
febo reviewed Jul 2, 2025
View reviewed changes
@Nagaprasadvr Nagaprasadvr requested a review from febo July 2, 2025 15:39
@Aursen
Copy link
Contributor

Aursen commented Jul 4, 2025

If we can get that for the next version, it could be great.

@sonicfromnewyoke sonicfromnewyoke mentioned this pull request Jul 4, 2025
Open
febo
febo reviewed Jul 7, 2025
View reviewed changes
febo
febo reviewed Jul 7, 2025
View reviewed changes
febo
febo reviewed Jul 7, 2025
View reviewed changes
febo
febo reviewed Jul 7, 2025
View reviewed changes
febo
febo reviewed Jul 7, 2025
View reviewed changes
febo
febo reviewed Jul 7, 2025
View reviewed changes
febo
febo reviewed Jul 7, 2025
View reviewed changes
febo
febo reviewed Jul 7, 2025
View reviewed changes
febo
febo reviewed Jul 7, 2025
View reviewed changes
febo
febo reviewed Jul 7, 2025
View reviewed changes
febo
febo reviewed Jul 7, 2025
View reviewed changes
Copy link
Collaborator

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few more nits.

@Nagaprasadvr Nagaprasadvr force-pushed the feat-add-token-2022-core-state-and-ixs branch from 4a43c2a to cc1a3eb Compare July 8, 2025 03:27
@Nagaprasadvr Nagaprasadvr force-pushed the feat-add-token-2022-core-state-and-ixs branch from cc1a3eb to c30d8d7 Compare July 15, 2025 03:56
@Nagaprasadvr Nagaprasadvr requested a review from febo July 15, 2025 03:57
febo
febo reviewed Jul 15, 2025
View reviewed changes
febo
febo reviewed Jul 15, 2025
View reviewed changes
Copy link
Collaborator

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, a final nit and this can go in.

@Nagaprasadvr Nagaprasadvr requested a review from febo July 16, 2025 06:42
@febo
Copy link
Collaborator

febo commented Jul 17, 2025

@Nagaprasadvr Could you rebase the PR so it gets the spellcheck in CI?

@Nagaprasadvr Nagaprasadvr force-pushed the feat-add-token-2022-core-state-and-ixs branch from c2f32ac to a6584d1 Compare July 17, 2025 08:34
@Nagaprasadvr
Copy link
Contributor Author

Nagaprasadvr commented Jul 17, 2025

@Nagaprasadvr Could you rebase the PR so it gets the spellcheck in CI?

done ser @febo

ananas-block
ananas-block reviewed Jul 23, 2025
View reviewed changes
Copy link

@ananas-block ananas-block left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looking forward to be able to use flexible token program ids!

Random idea, token22 and token instructions code look identical, save for the flexible token_program pubkey, and if so could be unified. The token22 instruction code could be wrapped or reexported in token/src/instructions.

@febo
Copy link
Collaborator

febo commented Jul 23, 2025

Nice, looking forward to be able to use flexible token program ids!

Random idea, token22 and token instructions code look identical, save for the flexible token_program pubkey, and if so could be unified. The token22 instruction code could be wrapped or reexported in token/src/instructions.

Yeah, I think the idea is to unify them under the Token-22 one since this is a superset of the token instructions.

@febo
Copy link
Collaborator

febo commented Jul 23, 2025

@Nagaprasadvr Could you rebase the PR so it gets the spellcheck in CI?

done ser @febo

Just missing passing CI. You can check how the spelling was fixed on the token one.

@Nagaprasadvr Nagaprasadvr force-pushed the feat-add-token-2022-core-state-and-ixs branch from a6584d1 to 556a043 Compare July 24, 2025 02:42
@Nagaprasadvr
Copy link
Contributor Author

Nagaprasadvr commented Jul 24, 2025

@Nagaprasadvr Could you rebase the PR so it gets the spellcheck in CI?

done ser @febo

Just missing passing CI. You can check how the spelling was fixed on the token one.

@febo i have fixed the docs

@Nagaprasadvr Nagaprasadvr force-pushed the feat-add-token-2022-core-state-and-ixs branch from 556a043 to 2b0f772 Compare July 24, 2025 03:00
Taylor123
Taylor123 reviewed Jul 28, 2025
View reviewed changes
@nabeel99
Copy link

nabeel99 commented Aug 5, 2025

is there any blocker to this getting merged soon , if so would love to help out, since we are using pinocchio rn and we have code dealing with t22 program not sure if there is any recommended alternative to use until its officially merged.

febo
febo approved these changes Aug 7, 2025
View reviewed changes
Copy link
Collaborator

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good – thanks!

@febo febo merged commit 55ecb47 into anza-xyz:main Aug 9, 2025
11 checks passed
@febo febo mentioned this pull request Aug 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@febo febo febo approved these changes

+2 more reviewers

@Taylor123 Taylor123 Taylor123 left review comments

@ananas-block ananas-block ananas-block left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Nagaprasadvr @Aursen @febo @nabeel99 @Taylor123 @ananas-block